search

JuliaEcosystem / PackageAnalyzer.jl

https://juliaecosystem.github.io/PackageAnalyzer.jl/dev/
MIT License
59 stars 5 forks source link

update to use RegistryInstances #68

Closed ericphanson closed 2 years ago

ericphanson commented 2 years ago

This allows us to work with compressed registries, and also offloads some of the parsing and path manipulation there.

I bumped it as a breaking release because we had documented RegistryEntry's as a way to use PackageAnalyzer, and this drops support for them in favor of RegistryInstance's PkgEntry object.

ericphanson commented 2 years ago

This should also fix the CI failures on main, I believe

ericphanson commented 2 years ago

Ok, now CI is passing but docs are failing:

Failed to add the ECDSA host key for IP address '140.82.114.3' to the list of known hosts (/home/runner/.ssh/known_hosts). git@github.com: Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. ┌ Error: Git failed to fetch git@github.com:JuliaEcosystem/PackageAnalyzer.jl.git │ This can be caused by a DOCUMENTER_KEY variable that is not correctly set up. │ Make sure that the environment variable is properly set up as a Base64-encoded string │ of the SSH private key. You may need to re-generate the keys with DocumenterTools. └ @ Documenter ~/.julia/packages/Documenter/yf96B/src/Documenter.jl:652 ┌ Error: Failed to push: │ exception = │ failed process: Process(setenv(/usr/bin/git fetch upstream,["DOCUMENTER_KEY=***", "PATH=/opt/hostedtoolcache/julia/1.6.7/x64/bin:/home/runner/.local/bin:/opt/pipx_bin:/home/runner/.cargo/bin:/home/runner/.config/composer/vendor/bin:/usr/local/.ghcup/bin:/home/runner/.dotnet/tools:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin", "DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1", "GITHUB_RUN_NUMBER=149", "GITHUB_REF_NAME=68/merge", "RUNNER_ARCH=X64", "PERFLOG_LOCATION_SETTING=RUNNER_PERFLOG", "ACCEPT_EULA=Y", "ANT_HOME=/usr/share/ant", "RUNNER_USER=runner" … "JAVA_HOME_11_X64=/usr/lib/jvm/temurin-11-jdk-amd64", "SELENIUM_JAR_PATH=/usr/share/java/selenium-server.jar", "GITHUB_TRIGGERING_ACTOR=ericphanson", "GITHUB_REPOSITORY_OWNER=JuliaEcosystem", "RUNNER_TEMP=/home/runner/work/_temp", "DOTNET_NOLOGO=1", "GITHUB_EVENT_NAME=pull_request", "OPENBLAS_MAIN_FREE=1", "ANDROID_NDK_HOME=/usr/local/lib/android/sdk/ndk/25.1.8937393", "AGENT_TOOLSDIRECTORY=/opt/hostedtoolcache"]), ProcessExited(128)) [128]

I can regen a documenter key and add it as a secret, but it seems weird it is failing

giordano commented 2 years ago

There's no deploy key: https://github.com/JuliaEcosystem/PackageAnalyzer.jl/settings/keys. I've had a few cases like this lately, some old keys disappeared.

ericphanson commented 2 years ago

I will merge, but I think we before we register v1.0 we may want to swap out registry=general_registry() for registries=reachable_registries() to support looking up packages from multiple registries off the bat

giordano commented 2 years ago

That's OK with me!