JuliaEditorSupport / atom-language-julia

A Julia language support package for the Atom editor
Other
52 stars 39 forks source link

Unicode letters break type name #259

Open Timeroot opened 2 years ago

Timeroot commented 2 years ago

When a type has a unicode letter (like Δ) in the name, this "breaks" the name and the hightlight stops before. I'm guessing this is some issue in what letters are viewed as continuations of type names. As an example, you can see this code in Roots.jl:

https://github.com/JuliaMath/Roots.jl/blob/master/src/Derivative/halley_like.jl#L131

struct ChebyshevLike <: AbstractΔMethod end

which highlights as

image

pfitzseb commented 2 years ago

This seems like a bug in the GH highlighter, specifically. Your examples is highlighted correctly in both VS Code and Atom (I've also added a test for that in #260).