search

JuliaEditorSupport / atom-language-julia

A Julia language support package for the Atom editor
Other
51 stars 39 forks source link

update regex to support multiline in julia-console #285

Open Pangoraw opened 2 months ago

Pangoraw commented 2 months ago

cc @adrhill

adrhill commented 1 month ago

Related issues: #282, #283

adrhill commented 1 month ago

@Pangoraw could you remind me how we tested this locally?

EDIT: GitHub linguist has a guide.

Pangoraw commented 1 month ago

You need nodejs and npm installed:

cd atom-language-julia
npm ci # install dependencies described in package-lock.json (instantiate in julia)
npm run test
Pangoraw commented 1 month ago

One think I am wondering is that maybe we should put the fix in the cson file and remove the json file since Github linguist seems to work fine with cson for now.

pfitzseb commented 1 month ago

Could also consider moving the source of truth into a template file like the actual julia grammar, but tbf it doesn't really make any sense except for consistency.