search

JuliaEditorSupport / julia-vim

Vim support for Julia.
http://julialang.org/
Other
752 stars 94 forks source link

`b:undo_ftplugin` should not reset indentation settings #315

Closed kyllingstad closed 5 months ago

kyllingstad commented 6 months ago

The b:undo_ftplugin variable defined in ftplugin/julia.vim resets indentation options like indentexpr. It shouldn't, because that script does not set those options, and therefore its undo action should not reset them.

These options should only be reset by the actions of b:undo_indent defined in indent/julia.vim (and they correctly are).

kyllingstad commented 6 months ago

I edited the description of this issue because it turned out that much of what I described was specific to my particular .vimrc setup. But the main issue still stands, I think.

dkearns commented 6 months ago

It looks like this was added to b:undo_ftplugin in https://github.com/JuliaEditorSupport/julia-vim/commit/7b71f094d467aa8960d31ec988ccdd2d817a2d12 before the author was probably aware of b:undo_indent.

carlobaldassi commented 5 months ago

Fixed in e36d07fa32194225be47af324456a729eebd2f7e (sorry about the wrong issue ref in the commit message, a cut&paste went wrong) Thanks for reporting this

chrisbra commented 5 months ago

@carlobaldassi can you send an update to Vim so we can fix https://github.com/vim/vim/issues/14419 there as well?