Closed benzwick closed 4 years ago
If you are willing to do a pull request, I will merge it. Currently, we are lacking an active maintenance of this package, thus after a couple of pull request I can also give contributor rights.
OK, when I have time I will look into this in more detail. We could also use e.g. UInt32
for storing indices to save space. This would allow node numbers up to
2^32 - 1 = 4294967295
which should be enough for most models that use .inp
as input.
See here for available number types: Integers and Floating-Point Numbers
Also a good idea. However, use of UInt32 needs to be optional (can be default), because we use stupidly high node numbers in Abaqus input files. We have standardized number ranges for different components to avoid node number collision. Our connections nodes have the highest numbers.
We might be able to improve performance by using concrete
Int
types instead of abstractInteger
types in the following places:Some quick benchmarks:
The maximum time is probably most important because we usually only do this once for each array.
See Avoid containers with abstract type parameters