JuliaFEM / Gmsh.jl

Gmsh.jl contains API for Gmsh: a three-dimensional finite element mesh generator. With the help of Gmsh.jl, it is possible add parametric model construction and/or automatic mesh generation to a FEM pipeline.
MIT License
53 stars 13 forks source link

Use jll package #21

Closed JonasIsensee closed 2 years ago

JonasIsensee commented 2 years ago

Hi,

I'm not sure if there's a consensus for the future of this package. However, since I wanted to use the Gmsh API, I changed things to work the same as in GridapGmsh.jl which uses the JLL package.

With these changes, it works for me locally on ubuntu.

closes #14 closes #7 probably fixes #20 (at least for me locally)

koehlerson commented 2 years ago

Sorry for the delayed reply, kinda forgot about this repo

fredrikekre commented 2 years ago

There are now new and shiny ways to override things from the JLL package, maybe that can be used instead? See https://docs.binarybuilder.org/stable/jll/#Overriding-the-artifacts-in-JLL-packages

JonasIsensee commented 2 years ago

Hi @koehlerson, no worries. About your questions: tbh I had no idea what I was doing and as you will have noticed, I essentially copied the code from https://github.com/gridap/GridapGmsh.jl/blob/master/deps/build.jl

I'm sure there's an easier way.

koehlerson commented 2 years ago

closed in favor for https://github.com/JuliaFEM/Gmsh.jl/pull/22