search

JuliaFinance / Currencies.jl

MIT License
20 stars 10 forks source link

Split data from code with DataPackage #102

Open femtotrader opened 5 years ago

femtotrader commented 5 years ago

Hello,

I wonder if data (for currencies but also crypto currencies #101 ) shouldn't be separated from code (to avoid too much updates of this package).

Working with datapackages (especially Julia library DataPackage.jl) could be considered.

Pinging @EricForgy (JuliaFinance) @roshii (crypto currencies support in Currencies.jl) @loleg (DataPackage.jl)

Unfortunately DataPackage.jl is currently not a registered packages and have some issues but if API of DataPackage.jl is becoming stable maybe we should consider using it, isn't it?

Best regards

femtotrader commented 5 years ago

I think

https://github.com/JuliaFinance/Currencies.jl/blob/master/src/data/country-codes.csv

was taken previously from

https://github.com/datasets/country-codes/ https://datahub.io/core/country-codes

which is a datapackage... (see datapackage.json in this repository).

Improving DataPackage Julia support could be a good way to give back to this open data ecosystem and could be a good real world example for testing features of such a library.

Adding a caching mechanism will probably be required... Maybe retriever have some good ideas to imitate

What is your opinion?

loleg commented 5 years ago

Thanks for the mention - we are still working on the DataPackage library, even if in the background at the moment - a use case like yours plus feedback on features and stability are very welcomed!