search

JuliaFinance / MarketObservables.jl

Provides standard types for financial markets
MIT License
5 stars 3 forks source link

Use test_* filenames for unit test files #4

Closed femtotrader closed 5 years ago

femtotrader commented 5 years ago

https://github.com/JuliaFinance/MarketObservables.jl/blob/392499db9d871707a65f550f481239c275dfc9e6/test/runtests.jl#L6

maybe test files name should start with test_ so you can automatically run all test_*

see https://github.com/JuliaCollections/DataStructures.jl/blob/master/test/runtests.jl

femtotrader commented 5 years ago

using Glob can help

roshii commented 5 years ago

Good suggestion, thanks. I'm pushing an update

roshii commented 5 years ago

Please review code and merge if good with you.

I propose we review each-other code like this: one does the pull request, the other merges it.

femtotrader commented 5 years ago

I'm fine with this idea... but I can't merge PR Ping @EricForgy

roshii commented 5 years ago

@femtotrader please try again, I just set @JuliaFinance/crypto team as admin of this repo

femtotrader commented 5 years ago

https://github.com/JuliaFinance/MarketObservables.jl/pull/7 merged! thanks for setting but I didn't saw the travis status in the PR.

Looking at https://travis-ci.com/JuliaFinance/MarketObservables.jl/jobs/195182542 it's unclear to me if tests are really running (I think star (*) is missing in test_*)

roshii commented 5 years ago

Good catch, * is indeed required I did commit directly to master