search

JuliaFirstOrder / ProximalAlgorithms.jl

Proximal algorithms for nonsmooth optimization in Julia
Other
130 stars 21 forks source link

Fix bug in line search in DRLS #53

Closed lostella closed 3 years ago

lostella commented 3 years ago

The check

if DRE_candidate <= DRE_curr - iter.c / iter.gamma * norm(state.res)^2

should be

if DRE_candidate <= DRE_curr - iter.c / iter.gamma * norm(state.res_prev)^2

Other code improvements are included.

codecov[bot] commented 3 years ago

Codecov Report

Merging #53 (9ce5452) into master (96fd0c2) will increase coverage by 0.01%. The diff coverage is 92.85%.

:exclamation: Current head 9ce5452 differs from pull request most recent head 5aeabe5. Consider uploading reports for the commit 5aeabe5 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   88.38%   88.40%   +0.01%     
==========================================
  Files          20       20              
  Lines         801      802       +1     
==========================================
+ Hits          708      709       +1     
  Misses         93       93
Impacted Files Coverage Δ
src/algorithms/drls.jl 91.37% <92.85%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96fd0c2...5aeabe5. Read the comment docs.