search

JuliaFolds / BangBang.jl

Immutables as mutables, mutables as immutables.
MIT License
108 stars 11 forks source link

Improve inferrability of `setproperty!!` #227

Closed tkf closed 2 years ago

tkf commented 2 years ago

Let's help the inference until name is lifted to the type domain. Adding @inline to the old implementation was enough. But it's better to use the constructor directly to relying another constprop.

close #226

codecov[bot] commented 2 years ago

Codecov Report

Merging #227 (9b968fb) into master (ef8c6d6) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files          23       23           
  Lines         536      536           
=======================================
  Hits          490      490           
  Misses         46       46
Flag Coverage Δ
unittests 91.41% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/base.jl 84.37% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef8c6d6...9b968fb. Read the comment docs.