search

JuliaFolds / BangBang.jl

Immutables as mutables, mutables as immutables.
MIT License
107 stars 11 forks source link

ZygoteRules -> ChainRules (2) #237

Open MasonProtter opened 1 year ago

MasonProtter commented 1 year ago

This is just https://github.com/JuliaFolds/BangBang.jl/pull/232 except I fixed up the whole Run.jl situation by updating the environments. I dropped julia versions pre-1.6 because it's not worth the CI time or hassle supporting something that's not even LTS.

Sorry @touchesir, I couldn't figure out how to push these changes to your branch so I just did this.

MasonProtter commented 1 year ago

I might just remove the benchmark script. Sounds useful to have, but I don't know how to maintain it.

codecov[bot] commented 1 year ago

Codecov Report

Merging #237 (c27c744) into master (d70a19b) will increase coverage by 0.28%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   91.52%   91.80%   +0.28%     
==========================================
  Files          23       23              
  Lines         531      537       +6     
==========================================
+ Hits          486      493       +7     
+ Misses         45       44       -1
Flag Coverage Δ
unittests 91.80% <100.00%> (+0.28%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/BangBang.jl 100.00% <ø> (ø)
src/chainrules.jl 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes