JuliaFolds / FLoops.jl

Fast sequential, threaded, and distributed for-loops for Julia—fold for humans™
MIT License
307 stars 6 forks source link

CompatHelper: bump compat for Setfield to 1, (keep existing compat) #128

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

This pull request changes the compat entry for the Setfield package from 0.3, 0.4, 0.5, 0.6, 0.7, 0.8 to 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 1. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 2 years ago

Codecov Report

Merging #128 (39ce57c) into master (87f4c39) will decrease coverage by 7.28%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   95.04%   87.75%   -7.29%     
==========================================
  Files           5        5              
  Lines         706      686      -20     
==========================================
- Hits          671      602      -69     
- Misses         35       84      +49     
Flag Coverage Δ
Pkg.test ?
Run.test 87.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/macro.jl 75.78% <0.00%> (-18.09%) :arrow_down:
src/reduce.jl 90.65% <0.00%> (-4.32%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

matbesancon commented 2 years ago

@tkf we are blocked for people using FrankWolfe.jl and FLoops because of Setfields, is there anything blocking for this merge?

matbesancon commented 2 years ago

seems like the manifest in test/env is not valid for some julia versions? Should it be committed?

tkf commented 2 years ago

@matbesancon I'm looking at the vanilla Pkg.test at the moment

tkf commented 2 years ago

Sorry for the wait! Releasing https://github.com/JuliaRegistries/General/pull/69624

matbesancon commented 2 years ago

thanks a lot!