JuliaFolds / Transducers.jl

Efficient transducers for Julia
https://juliafolds.github.io/Transducers.jl/dev/
MIT License
432 stars 24 forks source link

Associative string-splitting transducer #344

Closed tkf closed 4 years ago

tkf commented 4 years ago

Commit Message

Associative string-splitting transducer (#344)

Fix the word-splitting transducer in examples/words.jl to avoid re-ordering words. This assumes the inner reducing function to be associative. In turn, it makes the whole composite reducing function "associative" (in the sense that combine works).

Making it work requires collect to use a proper monoid (i.e., start(rf, Init) works).

codecov[bot] commented 4 years ago

Codecov Report

Merging #344 into master will decrease coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage   90.56%   90.52%   -0.05%     
==========================================
  Files          25       25              
  Lines        1494     1498       +4     
==========================================
+ Hits         1353     1356       +3     
- Misses        141      142       +1     
Impacted Files Coverage Δ
src/processes.jl 92.85% <100.00%> (+0.11%) :arrow_up:
src/core.jl 86.18% <0.00%> (-1.04%) :arrow_down:
src/progress.jl 90.81% <0.00%> (+1.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 31b2338...f4015c6. Read the comment docs.