JuliaFolds / Transducers.jl

Efficient transducers for Julia
https://juliafolds.github.io/Transducers.jl/dev/
MIT License
432 stars 24 forks source link

Define collect(::Foldable) rather than collect(::Eduction) #397

Closed tkf closed 4 years ago

tkf commented 4 years ago

Commit Message

Define collect(::Foldable) rather than collect(::Eduction) (#397)

This makes collect work with non-Eduction foldables. For example:

collect(withprogress(((sleep(0.01); x) for x in 1:100); interval=1e-3))
codecov[bot] commented 4 years ago

Codecov Report

Merging #397 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #397   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files          25       25           
  Lines        1530     1530           
=======================================
  Hits         1386     1386           
  Misses        144      144           
Impacted Files Coverage Δ
src/processes.jl 92.81% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3599fd2...bf825b3. Read the comment docs.