Closed tkf closed 4 years ago
Merging #412 into master will increase coverage by
1.22%
. The diff coverage is75.00%
.
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 89.52% 90.75% +1.22%
==========================================
Files 25 25
Lines 1585 1600 +15
==========================================
+ Hits 1419 1452 +33
+ Misses 166 148 -18
Flag | Coverage Δ | |
---|---|---|
#unittests | 90.75% <75.00%> (+1.22%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
src/basics.jl | 90.00% <50.00%> (+8.42%) |
:arrow_up: |
src/processes.jl | 92.68% <83.33%> (-0.36%) |
:arrow_down: |
src/library.jl | 93.15% <0.00%> (-0.28%) |
:arrow_down: |
src/show.jl | 89.51% <0.00%> (+0.07%) |
:arrow_up: |
src/unordered.jl | 96.61% <0.00%> (+0.31%) |
:arrow_up: |
src/progress.jl | 89.79% <0.00%> (+1.02%) |
:arrow_up: |
src/core.jl | 85.56% <0.00%> (+1.06%) |
:arrow_up: |
src/groupby.jl | 82.14% <0.00%> (+5.77%) |
:arrow_up: |
src/reduce.jl | 84.55% <0.00%> (+9.14%) |
:arrow_up: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1f67507...29d65cb. Read the comment docs.
The following snippets shows a big jump in the compilation latency after eb430cf76a5c25aa909858c20424aead21cfecfd (#403):
Commit Message
Improve compilation latency for non-inferable case (#412)
The tail-call pattern introduced in eb430cf76a5c25aa909858c20424aead21cfecfd (#403) for linear indexing arrays seem to invoke a large compiler latency (see #412 for an example). This patch tries to mitigate the problem by introducing a different more dynamic code path for
__foldl__
on arrays when the reducing function is not inferrable.