search

JuliaFolds / Transducers.jl

Efficient transducers for Julia
https://juliafolds.github.io/Transducers.jl/dev/
MIT License
432 stars 24 forks source link

Call combine on remote #467

Closed tkf closed 3 years ago

tkf commented 3 years ago

This is a slight optimization on top of #466.

Commit Message

Call combine on remote (#467)

Now fetch and combine of the accumulator futures are called on a remote worker rather than locally. This strategy could be nicer in terms of performance. But, more importantly, it provides an alternative fix to #466.

codecov[bot] commented 3 years ago

Codecov Report

Merging #467 (282a073) into master (bb0eb65) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   91.65%   91.65%   -0.01%     
==========================================
  Files          32       32              
  Lines        2122     2121       -1     
==========================================
- Hits         1945     1944       -1     
  Misses        177      177
Flag Coverage Δ
unittests 91.65% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dreduce.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb0eb65...282a073. Read the comment docs.