search

JuliaFolds / Transducers.jl

Efficient transducers for Julia
https://juliafolds.github.io/Transducers.jl/dev/
MIT License
432 stars 24 forks source link

Don't restack if pointer-free #504

Closed tkf closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #504 (4543026) into master (3f52fa9) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #504      +/-   ##
==========================================
+ Coverage   93.41%   93.45%   +0.04%     
==========================================
  Files          32       32              
  Lines        2217     2217              
==========================================
+ Hits         2071     2072       +1     
+ Misses        146      145       -1
Flag Coverage Δ
Pkg.test 89.62% <100.00%> (+0.04%) :arrow_up:
Run.test 93.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/AutoObjectsReStacker.jl 95.65% <100.00%> (ø)
src/nondeterministic_threading.jl 89.79% <0.00%> (+1.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f52fa9...4543026. Read the comment docs.

tkf commented 2 years ago

It looks like restack still matters for pointer-free types https://github.com/JuliaFolds/Transducers-data/blob/multi-thread-benchmark-results/2022/01/29/054144/result.md

ID time ratio memory ratio
... ... ...
["partition_length_maximum", "rand", "reduce"] 5.07 (5%) :x: 1.00 (1%)

See also: