JuliaFolds2 / ChunkSplitters.jl

Splitting collections into chunks
https://juliafolds2.github.io/ChunkSplitters.jl/
MIT License
50 stars 7 forks source link

return always the same type of range #12

Closed lmiq closed 1 year ago

lmiq commented 1 year ago

Fixes #10

@lxvm

I think this is a simpler solution to the issue you identified. I've added your mwe as an inference test as well. Please feel free to comment and suggest improvements in the PR, or to explain why (if) you think your solution is better. I may be missing something.

codecov[bot] commented 1 year ago

Codecov Report

Merging #12 (34ff29f) into main (3aa18b8) will increase coverage by 1.62%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   85.41%   87.03%   +1.62%     
==========================================
  Files           1        1              
  Lines          48       54       +6     
==========================================
+ Hits           41       47       +6     
  Misses          7        7              
Files Coverage Δ
src/ChunkSplitters.jl 87.03% <100.00%> (+1.62%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

lxvm commented 1 year ago

Thanks @lmiq, I think your solution works better!

lmiq commented 1 year ago

Thanks for reporting and for the mwe, that was perfect.