Closed lmiq closed 5 months ago
@carstenbauer
If you want to comment, please let me know. I think this is an important change. I was getting quite important type instabilities in trivial examples because of this.
Otherwise I'll just merge it asap.
Attention: Patch coverage is 93.10345%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 94.39%. Comparing base (
9cf0250
) to head (f1be5e9
).
Files | Patch % | Lines |
---|---|---|
src/ChunkSplitters.jl | 93.10% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I found that the introduction of the
size
option created a potentially type-instability in the construction ofChunk
, because thechunks
function did not specialize to theConstraint
parameter. To fix that, I made the defaults ofn
andsize
to benothing
, such that the finalConstraint
type ofChunk
is known from their types.Before:
Now: