JuliaFolds2 / OhMyThreads.jl

Simple multithreading in julia
https://juliafolds2.github.io/OhMyThreads.jl/
MIT License
139 stars 9 forks source link

Prepare for ChunkSplitters 3.0 #119

Closed carstenbauer closed 1 month ago

carstenbauer commented 1 month ago

OhMyThreads API Changes:

TODOs:

carstenbauer commented 1 month ago

If one uses the linked PR of ChunkSplitters, all tests are passing locally.

carstenbauer commented 1 month ago

@MasonProtter would be great if you could give this a quick look. Would like to merge and release this in the next couple of days.

carstenbauer commented 1 month ago

Apart from the const vs using discussion above, this seems to be good to go.

(What one could do is walk over the docs and see if any of the examples could be simplified by using chunks instead of index_chunks. But that's neither important nor does it have to be done in this PR.)

carstenbauer commented 1 month ago

I'll merge this. We don't have to register the new version right away to maybe make other breaking changes (e.g. related to #124).