search

JuliaFusion / GuidingCenterOrbits.jl

Julia package for calculating guiding-center orbits in magnetic equilibrium
Other
9 stars 1 forks source link

Retcodes to Symbols deprecated in Julia v1.9 #15

Open henrikjaerleblad opened 1 year ago

henrikjaerleblad commented 1 year ago

When orbit-integrating now (Julia v1.9)(using orbit.jl/integrate()), one gets the following warning

@Warning: Backwards compatability support of the new return codes to Symbols will be deprecated with the Julia v1.9 release. Please see https://docs.sciml.ai/SciMLBase/stable/interfaces/Solutions/#retcodes for more information

If one reads the content provided with the link, I interpret it as we need to change e.g. sol.retcode == :Success to SciMLBase.successful_retcode(sol) everywhere in orbits.jl (and callbacks.jl?). That is, remove Symbol syntax

@lstagner can you fix this?

lstagner commented 1 year ago

Thats annoying. For now we could just put a compat limit.

henrikjaerleblad commented 1 year ago

Alright let's do that for now