search

JuliaGNI / GeometricProblems.jl

Example problems for GeometricIntegrators.jl
MIT License
5 stars 0 forks source link

Keyword argument: `params` or `parameters` #65

Open benedict-96 opened 4 months ago

benedict-96 commented 4 months ago

Sometimes params is used as a keyword argument and sometimes it's parameters. What should we settle on?

michakraus commented 4 months ago

It should be parameters. I already changed that in most places in the last refactoring. Did I miss any occurrences of params?

benedict-96 commented 4 months ago

Oh, ok. This is mostly a problem with my code I think, e.g. in: https://github.com/JuliaGNI/GeometricProblems.jl/blob/hodeensemble/src/coupled_harmonic_oscillator.jl

It could maybe also be changed here: https://github.com/JuliaGNI/GeometricProblems.jl/blob/hodeensemble/src/lotka_volterra_3d.jl

I will fix this!

benedict-96 commented 4 months ago

https://github.com/JuliaGNI/GeometricProblems.jl/pull/66 gets rid of this problem for the coupled harmonic oscillator.