search

JuliaGNI / GeometricProblems.jl

Example problems for GeometricIntegrators.jl
MIT License
5 stars 0 forks source link

Added `hodeensemble` (for the coupled harmonic oscillator) #66

Closed benedict-96 closed 4 months ago

benedict-96 commented 4 months ago

I added a function hodeensemble for the coupled harmonic oscillator. This can be called with two vectors of initial conditions or a vector of parameters.

@michakraus, could you please check if the interface is approximately what it should be? In that case I could implement something similar for all other hodeproblems. Also: I think the two/three methods for hodeensemble don't depend on the particular problem and we could implement them once for all our problems (i.e. in a file hodeensembles.jl that's then included in all modules in GeometricProblems). Would that work?

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 32.68%. Comparing base (5473162) to head (9b308cd).

Files Patch % Lines
src/coupled_harmonic_oscillator.jl 50.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ========================================== + Coverage 32.08% 32.68% +0.59% ========================================== Files 30 30 Lines 2010 2013 +3 ========================================== + Hits 645 658 +13 + Misses 1365 1355 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benedict-96 commented 4 months ago

There is an additional routine _hodeensemble because we need to dispatch over parameters (keyword argument).

benedict-96 commented 4 months ago

Set this pr to "draft". Will have to fix https://github.com/JuliaGNI/GeometricEquations.jl/issues/18 first.