search

JuliaGNI / GeometricProblems.jl

Example problems for GeometricIntegrators.jl
MIT License
5 stars 0 forks source link

Linear wave #67

Closed benedict-96 closed 4 months ago

benedict-96 commented 4 months ago

Added linear wave equation as we have it in https://arxiv.org/abs/2312.10004.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 32.08%. Comparing base (b05d3b7) to head (a698959).

Files Patch % Lines
src/linear_wave.jl 8.33% 22 Missing :warning:
src/bump_initial_condition.jl 86.36% 6 Missing :warning:
src/toda_lattice.jl 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #67 +/- ## ========================================== + Coverage 31.76% 32.08% +0.32% ========================================== Files 29 30 +1 Lines 1961 2010 +49 ========================================== + Hits 623 645 +22 - Misses 1338 1365 +27 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benedict-96 commented 4 months ago

I will get rid of ForwardDiff dependency and then mark as "ready for review" (again).

benedict-96 commented 4 months ago

Removed ForwardDiff dependency (it's still used for testing purposes however) and changed get -> compute.