search

JuliaGPU / Adapt.jl

Other
86 stars 24 forks source link

Provide database of array wrappers. #10

Closed maleadt closed 5 years ago

maleadt commented 5 years ago

Bit of an ugly beast, so feel free to bikeshed the structure everyone. Used in https://github.com/JuliaGPU/GPUArrays.jl/pull/172 to fix https://github.com/JuliaGPU/CuArrays.jl/issues/173.

codecov-io commented 5 years ago

Codecov Report

Merging #10 into master will decrease coverage by 20%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #10    +/-   ##
=====================================
- Coverage     100%   80%   -20%     
=====================================
  Files           2     2            
  Lines           6    10     +4     
=====================================
+ Hits            6     8     +2     
- Misses          0     2     +2
Impacted Files Coverage Δ
src/base.jl 85.71% <100%> (-14.29%) :arrow_down:
src/Adapt.jl 66.66% <0%> (-33.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 731f701...608e461. Read the comment docs.

vchuravy commented 5 years ago

Yeah it looks ugly, but that should be fine :)

One thing I have been thinking about is to have a trait adaptive and a trait storage. Where storage is the actual underlying storage type.