JuliaGPU / Adapt.jl

Other

90 stars 24 forks source link

Add reshaped array wrapper #13

Closed DhairyaLGandhi closed 5 years ago

DhairyaLGandhi commented 5 years ago

Useful for cases when reshaping is necessary.

Ref: FluxML/Flux.jl#536

codecov-io commented 5 years ago

Codecov Report

Merging #13 into master will not change coverage. The diff coverage is n/a.

@@         Coverage Diff          @@
##           master   #13   +/-   ##
====================================
  Coverage      75%   75%           
====================================
  Files           2     2           
  Lines          12    12           
====================================
  Hits            9     9           
  Misses          3     3

Impacted Files	Coverage Δ
src/base.jl	`77.77% <ø> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f5b711...e2fdd66. Read the comment docs.

MikeInnes commented 5 years ago

:+1: Thanks!

maleadt commented 5 years ago

This didn't get a test though. @dhairyagandhi96, care to add one? Thanks!

DhairyaLGandhi commented 5 years ago

Sure, absolutely! I'm on it

maleadt commented 5 years ago

Any update?

maleadt commented 5 years ago

https://github.com/JuliaGPU/Adapt.jl/commit/4cfb6e9ae07e68270c0ddc9e4d677dbcba6e2bc2

DhairyaLGandhi commented 5 years ago

Ah, I just saw the message. Thanks for that! I thought I had already sent that PR. My apologies.

maleadt commented 5 years ago

No problem, figured it would be easier to do it myself before losing track of the issue.