search

JuliaGPU / Adapt.jl

Other
86 stars 24 forks source link

Update runtests.jl #14

Closed musm closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #14 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff          @@
##           master   #14   +/-   ##
====================================
  Coverage      75%   75%           
====================================
  Files           2     2           
  Lines          12    12           
====================================
  Hits            9     9           
  Misses          3     3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74a0499...a702718. Read the comment docs.

MikeInnes commented 5 years ago

Why?

musm commented 5 years ago

Doesn't really matter, but it's less confusing and convention I believe that is widely followed.
Wrapper(x::T) where T = Wrapper{T}(x) looks like Wrapper(x::T) where (T = Wrapper{T}(x)) , braces make it obvious.

Feel free to close if you don't care/or prefer the current style

vchuravy commented 5 years ago

I personally prefer the dropped braces for single types

MikeInnes commented 5 years ago

I'm happy to go with consensus among current GPU maintainers, but it sounds like we're not worried about this. Thanks anyway @musm.