maleadt commented 3 years ago

Fixes https://github.com/JuliaGPU/Adapt.jl/issues/30.

This is breaking, but contrary to the previous breaking release the necessary downstream changes are backwards compatible. That's a big deal, as it doesn't lock the ecosystem in a pre- and post-update state: packages will be able to upgrade (as Adapt.ndims aliases to Base.ndims pre-update, so nothing changes), and Adapt.jl will finally do too if it's compatible with all installed packages.

cc @chrisrackauckas @timholy

codecov[bot] commented 3 years ago

Codecov Report

Merging #36 (8ee4b11) into master (f298353) will decrease coverage by 2.85%. The diff coverage is 30.76%.

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
- Coverage   68.57%   65.71%   -2.86%     
==========================================
  Files           3        3              
  Lines          35       35              
==========================================
- Hits           24       23       -1     
- Misses         11       12       +1

Impacted Files	Coverage Δ
src/wrappers.jl	`66.66% <30.76%> (-3.71%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f298353...8ee4b11. Read the comment docs.

ChrisRackauckas commented 3 years ago

Seems like a good solution to me.

JuliaGPU / Adapt.jl

Don't pirate Base methods for WrappedArray queries. #36

Codecov Report