JuliaGPU / Adapt.jl

Other
86 stars 24 forks source link

Improve typestability. #53

Closed N5N3 closed 1 year ago

N5N3 commented 1 year ago
  1. replace x->adapt(to,x) with AdaptTo(to) to avoid https://github.com/JuliaLang/julia/issues/23618. (We have adaptor <: Type, e.g. Array)
  2. use PermutedDimsArray's inner constructor to avoid https://github.com/JuliaLang/julia/issues/46008
codecov[bot] commented 1 year ago

Codecov Report

Merging #53 (656841b) into master (d9f852a) will increase coverage by 2.64%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   81.48%   84.12%   +2.64%     
==========================================
  Files           5        5              
  Lines          54       63       +9     
==========================================
+ Hits           44       53       +9     
  Misses         10       10              
Impacted Files Coverage Δ
src/Adapt.jl 100.00% <100.00%> (ø)
src/base.jl 90.90% <100.00%> (ø)
src/wrappers.jl 75.00% <100.00%> (+3.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9f852a...656841b. Read the comment docs.

maleadt commented 1 year ago

Thanks!

mcabbott commented 1 year ago

Would it be possible to make a release with this method in it?

maleadt commented 1 year ago

Sure. Just tagged 3.4