JuliaGPU / Adapt.jl

Other
86 stars 24 forks source link

Adapt to static arrays #59

Closed ChrisRackauckas closed 1 year ago

ChrisRackauckas commented 1 year ago

Uses package extensions so that it does not add the dependency. Is setup for backwards compatibility to pre-1.9 versions.

Should follow up with https://github.com/JuliaArrays/ArrayInterface.jl/pull/380

maleadt commented 1 year ago

Ah interesting. Until now we've required packages to maintain their own adaptors, but with something as fundamental as StaticArrays, and the ability to have extension packages, I guess we could consider maintaining a couple of those here.

codecov[bot] commented 1 year ago

Codecov Report

Base: 83.58% // Head: 82.85% // Decreases project coverage by -0.73% :warning:

Coverage data is based on head (fd54b35) compared to base (3d592b4). Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #59 +/- ## ========================================== - Coverage 83.58% 82.85% -0.73% ========================================== Files 5 6 +1 Lines 67 70 +3 ========================================== + Hits 56 58 +2 - Misses 11 12 +1 ``` | [Impacted Files](https://codecov.io/gh/JuliaGPU/Adapt.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU) | Coverage Δ | | |---|---|---| | [ext/AdaptStaticArraysExt.jl](https://codecov.io/gh/JuliaGPU/Adapt.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU#diff-ZXh0L0FkYXB0U3RhdGljQXJyYXlzRXh0Lmps) | `0.00% <0.00%> (ø)` | | | [src/Adapt.jl](https://codecov.io/gh/JuliaGPU/Adapt.jl/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU#diff-c3JjL0FkYXB0Lmps) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ChrisRackauckas commented 1 year ago

So does that mean it will merge? Or that I should open this at StaticArrays?

maleadt commented 1 year ago

No this should be fine to merge here.