JuliaGPU / Adapt.jl

Other
86 stars 24 forks source link

Fix StaticArrays extension. #62

Closed maleadt closed 1 year ago

maleadt commented 1 year ago

Fixes https://github.com/JuliaGPU/Adapt.jl/pull/59, which introduced a broken extension package (didn't load, didn't actually adapt) with nonfunctional tests.

Closes https://github.com/JuliaGPU/Adapt.jl/issues/61

cc @ChrisRackauckas

codecov[bot] commented 1 year ago

Codecov Report

Base: 82.85% // Head: 84.50% // Increases project coverage by +1.64% :tada:

Coverage data is based on head (a7c5739) compared to base (47f5040). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head a7c5739 differs from pull request most recent head 301d046. Consider uploading reports for the commit 301d046 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #62 +/- ## ========================================== + Coverage 82.85% 84.50% +1.64% ========================================== Files 6 6 Lines 70 71 +1 ========================================== + Hits 58 60 +2 + Misses 12 11 -1 ``` | [Impacted Files](https://codecov.io/gh/JuliaGPU/Adapt.jl/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU) | Coverage Ξ” | | |---|---|---| | [ext/AdaptStaticArraysExt.jl](https://codecov.io/gh/JuliaGPU/Adapt.jl/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU#diff-ZXh0L0FkYXB0U3RhdGljQXJyYXlzRXh0Lmps) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [src/Adapt.jl](https://codecov.io/gh/JuliaGPU/Adapt.jl/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU#diff-c3JjL0FkYXB0Lmps) | `100.00% <100.00%> (ΓΈ)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGPU)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ChrisRackauckas commented 1 year ago

Thanks for catching that. How come the test didn't run correctly?

ChrisRackauckas commented 1 year ago

oh forgot the @test πŸ˜…πŸ˜…πŸ˜…πŸ˜…πŸ˜…πŸ˜…πŸ˜