search

JuliaGPU / CLBLAS.jl

CLBLAS integration for Julia
Apache License 2.0
22 stars 14 forks source link

"clblas" -> "homebrew/science/clblas" #35

Closed dlfivefifty closed 7 years ago

dlfivefifty commented 7 years ago

Fixes brew name

musm commented 7 years ago

Does this not require @osx Homebrew in the REQUIRE file?

dlfivefifty commented 7 years ago

That's more a comment about the branch sd/osx then this pull request, but I can fix it

dlfivefifty commented 7 years ago

REQUIRE file already has @osx Homebrew. Note that this pull request is in to the sd/osx branch, not the main branch

musm commented 7 years ago

ah... ignore my comment then

dfdx commented 7 years ago

Travis isn't happy because CI isn't configured to work with OpenCL-enabled devices, but it's a separate issue. Do tests pass on your machine?

dlfivefifty commented 7 years ago

No, but due to https://github.com/JuliaGPU/CLBLAS.jl/issues/32

SimonDanisch commented 7 years ago

I guess we can merge this then and figure out #32 separately!

dfdx commented 7 years ago

This doesn't make much sense if MacOS version eventually doesn't work, but I agree that it also doesn't hurt if we have it merged.