search

JuliaGPU / CUDA.jl

CUDA programming in Julia.
https://juliagpu.org/cuda/
Other
1.16k stars 206 forks source link

Mark more methods as device methods #2336

Open vchuravy opened 2 months ago

vchuravy commented 2 months ago

Motivated by https://github.com/JuliaLang/julia/pull/54155

maleadt commented 2 months ago

Hmm, I purposefully didn't want to overuse overloads as they break e.g. Revise...

vchuravy commented 2 months ago

Yeah :/

Did you ever check why Revise breaks? Jameson mentioned a few weeks ago that OverlayMethod tables don't participate in invalidations correctly. (cc: @aviatesk)

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 60.34%. Comparing base (c7f880c) to head (36c125d).

:exclamation: Current head 36c125d differs from pull request most recent head 39549e6

Please upload reports for the commit 39549e6 to get more accurate results.

Files Patch % Lines
src/precompile.jl 12.50% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## vc/precompile_tools #2336 +/- ## ======================================================= + Coverage 59.96% 60.34% +0.37% ======================================================= Files 156 156 Lines 14989 14893 -96 ======================================================= - Hits 8988 8987 -1 + Misses 6001 5906 -95 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maleadt commented 2 months ago

Jameson mentioned a few weeks ago that OverlayMethod tables don't participate in invalidations correctly.

Yeah, that seems plausible: https://github.com/timholy/Revise.jl/issues/646#issuecomment-1193766431