search

JuliaGPU / CUDA.jl

CUDA programming in Julia.
https://juliagpu.org/cuda/
Other
1.2k stars 218 forks source link

Enzyme: Forward mode sync #2369

Closed wsmoses closed 4 months ago

wsmoses commented 4 months ago

@vchuravy for fixing https://buildkite.com/julialang/kernelabstractions-dot-jl/builds/931#018f654d-0616-4d67-8089-c01729873000

vchuravy commented 4 months ago 
Error in testset libraries/enzyme:
Test Failed at /var/lib/buildkite-agent/builds/gpuci-16/julialang/cuda-dot-jl/test/libraries/enzyme.jl:27
  Expression: all(dA .≈ 2:2:128)
Error in testset libraries/enzyme:
Error During Test at /var/lib/buildkite-agent/builds/gpuci-16/julialang/cuda-dot-jl/test/setup.jl:62
  Got exception outside of a @test
  LoadError: UndefVarError: batch_width not defined
  Stacktrace:
maleadt commented 4 months ago

Let's mark this as draft to save on CI resources until tests initially pass.

wsmoses commented 4 months ago

@maleadt okay I fixed the minor typos that hopefully should let it pass.

Assuming it passes, does it look good to you?

wsmoses commented 4 months ago

@maleadt admittedly this is a bit greedy of a request, but would it be possible to release (perhaps via backport since I know you're working on some breaking changes) the current EnzymeCUDA functionality.

This in particular is needed to re-fix KA+Enzyme CI [and other downstream ML users would like].

maleadt commented 4 months ago

I'd rather let the master branch bake for a while more. Can you create a PR against https://github.com/JuliaGPU/CUDA.jl/tree/release-5.3 with the commits (git cherry-pick ...) you need?

maleadt commented 4 months ago

@wsmoses: https://github.com/JuliaRegistries/General/pull/106889