search

JuliaGPU / CUDA.jl

CUDA programming in Julia.
https://juliagpu.org/cuda/
Other
1.2k stars 218 forks source link

Enzyme: support fill #2371

Closed wsmoses closed 4 months ago

wsmoses commented 4 months ago

@vchuravy could this get a review, it's blocking some ML users

maleadt commented 4 months ago

Let's mark this as draft to save on CI resources until tests initially pass.

wsmoses commented 4 months ago

@maleadt okay I fixed the minor typos that hopefully should let it pass.

Assuming it passes, does it look good to you?

maleadt commented 4 months ago

Assuming it passes, does it look good to you?

I'm unfamiliar with Enzyme, so I can't say much about the change.

The fact that it's very Enzyme specific (while using CUDA.jl-internals that are likely to break) actually makes me somewhat uncomfortable carrying this in CUDA.jl, even as a package extension, but as long as you and @vchuravy are happy to maintain it I guess it's fine to have (and test) this functionality...

wsmoses commented 4 months ago

yeah we commit to maintaining. And yeah that's why I think it makes most sense as an extension here (since it can follow cuda.jl internal changes correctly), since the enzymerules API is intentionally stable.