search

JuliaGPU / CUDA.jl

CUDA programming in Julia.
https://juliagpu.org/cuda/
Other
1.16k stars 206 forks source link

Run full GC when under very high memory pressure. #2421

Closed maleadt closed 1 week ago

maleadt commented 2 weeks ago

x-ref https://github.com/JuliaGPU/AMDGPU.jl/pull/645

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.27%. Comparing base (a72a133) to head (23b0391).

Files Patch % Lines
src/memory.jl 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2421 +/- ## ======================================= Coverage 73.27% 73.27% ======================================= Files 157 157 Lines 15197 15197 ======================================= Hits 11135 11135 Misses 4062 4062 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maleadt commented 2 weeks ago

@pxl-th I take it you've verified that this doesn't regress things and is good to have?

pxl-th commented 1 week ago

Yes, it helps. Although for some really intense workloads it is still not enough (observed with AMDGPU). Probably needs further finetuning

maleadt commented 1 week ago

Great, thanks, then we can start with this already.