search

JuliaGPU / oneAPI.jl

Julia support for the oneAPI programming toolkit.
https://juliagpu.org/oneapi/
Other
179 stars 21 forks source link

Improve the dispatch for sparse routines #410

Closed amontoison closed 5 months ago

amontoison commented 5 months ago

@maleadt Should we define AbstractoneSparseArray or AbstractOneSparseArray?

off-topic: We have the following error when we use the artifact oneAPI_Support_jll.jl and not the local one:

INTEL MKL ERROR: /root/.cache/julia-buildkite-plugin/depots/
05c310bb-cd1d-4bbf-ad62-61f2372c55f0/artifacts/
dacc6471ef6945fc42d4c7881bb431b19e138ba3/lib/libmkl_avx512.so.2: 
cannot open shared object file: No such file or director
maleadt commented 5 months ago

Should we define AbstractoneSparseArray or AbstractOneSparseArray?

Seeing how we went with oneWrappedArray, maybe oneAbstractSparseArray to preserve capitalization? In any case, neither of the options are really pleasing, I probably shouldn't have went with the lower-case one prefix (but it's what Intel does with all the oneAPI libraries, so seemed sensible).

amontoison commented 5 months ago

Thanks @maleadt! oneAbstractSparseArray is fine for me. I also fixed the issue with the artifact, a dependency was missing in the JLL. All tests passed now :heavy_check_mark:

What do you think of a new release of oneAPI.jl after this PR?

maleadt commented 5 months ago

What do you think of a new release of oneAPI.jl after this PR?

I was hoping to also include 1.11 support, which also requires a minor version bump.