search

JuliaGaussianProcesses / AbstractGPs.jl

Abstract types and methods for Gaussian Processes.
https://juliagaussianprocesses.github.io/AbstractGPs.jl/dev
Other
220 stars 21 forks source link

revert change of FiniteGP constructor from #236 to avoid breaking downstream packages #310

Closed st-- closed 2 years ago

st-- commented 2 years ago

The

FiniteGP(f::AbstractGP, x::AbstractVector, σ²::Real=default_σ²) = FiniteGP(f, x, ScalMat(length(x), σ²))

unfortunately ended up breaking ApproximateGPs, so this reverts that specific change of #236.

I'll move this constructor change into #306 instead.

codecov[bot] commented 2 years ago

Codecov Report

Merging #310 (5119b0b) into master (c126765) will decrease coverage by 0.26%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   97.90%   97.64%   -0.27%     
==========================================
  Files          10       10              
  Lines         382      382              
==========================================
- Hits          374      373       -1     
- Misses          8        9       +1
Impacted Files Coverage Δ
src/finite_gp_projection.jl 100.00% <100.00%> (ø)
src/util/common_covmat_ops.jl 95.23% <0.00%> (-2.39%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c126765...5119b0b. Read the comment docs.