search

JuliaGaussianProcesses / AbstractGPs.jl

Abstract types and methods for Gaussian Processes.
https://juliagaussianprocesses.github.io/AbstractGPs.jl/dev
Other
218 stars 20 forks source link

Fix typo in intro example #379

Closed willtebbutt closed 1 year ago

willtebbutt commented 1 year ago

Summary

Fixes noise-related problem raised in #378

Proposed changes

Add the correct noise variance wherever posterior log marginal likelihoods are asked for.

What alternatives have you considered?

None

Breaking changes

N/A

codecov[bot] commented 1 year ago

Codecov Report

Patch has no changes to coverable lines.

:loudspeaker: Thoughts on this report? Let us know!.

willtebbutt commented 1 year ago

lgtm... I'm just thinking if it'd be more helpful to have an explicit variable noise_var = 0.1 and then use that in the arguments ?

This is a good point. I'll modify this, then merge when CI passes.