search

JuliaGaussianProcesses / AbstractGPs.jl

Abstract types and methods for Gaussian Processes.
https://juliagaussianprocesses.github.io/AbstractGPs.jl/dev
Other
218 stars 20 forks source link

fix deprecation of `dtc` #380

Closed st-- closed 1 year ago

st-- commented 1 year ago

The deprecations in #361 had one flaw: previously,

dtc(VFE(fz), fx, y)

was technically correct (though it would have been better form to use the DTC alias defined as const DTC = VFE instead).

However, the deprecations passed this on to approx_log_evidence, which then would just compute the VFE ELBO.

This PR catches this special case.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/deprecations.jl 100.00%

:loudspeaker: Thoughts on this report? Let us know!.