JuliaGaussianProcesses / ApproximateGPs.jl

Approximations for Gaussian processes: sparse variational inducing point approximations, Laplace approximation, ...

https://juliagaussianprocesses.github.io/ApproximateGPs.jl/dev

Other

35 stars 6 forks source link

Fix file size of notebook #103

Closed devmotion closed 2 years ago

devmotion commented 2 years ago

Fixes the file size of the notebook (currently 21MB) and replaces https://github.com/JuliaGaussianProcesses/ApproximateGPs.jl/pull/102.

Edit: With this PR file size is 588kB: https://github.com/JuliaGaussianProcesses/ApproximateGPs.jl/blob/gh-pages/previews/PR103/examples/a-regression.ipynb.

codecov[bot] commented 2 years ago

Codecov Report

Merging #103 (423cda5) into master (8b0002c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files           4        4           
  Lines         285      285           
=======================================
  Hits          273      273           
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b0002c...423cda5. Read the comment docs.

st-- commented 2 years ago

Though I'd like to understand why not just use DisplayAs.PNG(plt) #hide regardless of output format (as originally proposed in #98, though then replaced before merging), shouldn't that resolve the issue the same way?

devmotion commented 2 years ago

No, # hide only affects markdown output but that already works fine due to the fmt setting and the only issue is the notebook output. https://fredrikekre.github.io/Literate.jl/v2/fileformat/#Filtering-lines