JuliaGaussianProcesses / ApproximateGPs.jl

Approximations for Gaussian processes: sparse variational inducing point approximations, Laplace approximation, ...
https://juliagaussianprocesses.github.io/ApproximateGPs.jl/dev
Other
35 stars 6 forks source link

Test JuliaGPsDocs on repo #124

Closed theogf closed 2 years ago

theogf commented 2 years ago

Time for battle testing!

theogf commented 2 years ago

The errors seem unrelated to the PR...

st-- commented 2 years ago

The errors seem unrelated to the PR...

Yes, my sincere apologies! Turns out AbstractGPs 0.5.10 was breaking after all :disappointed: @theogf once you've merged https://github.com/JuliaGaussianProcesses/AbstractGPs.jl/pull/310 (& released) and https://github.com/JuliaGaussianProcesses/ApproximateGPs.jl/pull/125, the build issues should be solely due to your own mistakes again ;)

theogf commented 2 years ago

Yay! looks great. The only thing I'd prefer changed is for it not to be called "example.md".... is it not possible to have it by name.md as before? if it's got to be hardcoded I'd prefer index.md ...

It is much easier to have a fixed name (this follow the same constraint as the "script.jl" thing. But sure we could go for another name

theogf commented 2 years ago

@devmotion was already using index.md, let's go with this then

codecov[bot] commented 2 years ago

Codecov Report

Merging #124 (2cfa705) into master (b4f17c3) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   93.30%   93.30%           
=======================================
  Files           4        4           
  Lines         284      284           
=======================================
  Hits          265      265           
  Misses         19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4f17c3...2cfa705. Read the comment docs.

st-- commented 2 years ago

Seems to be working fine now. Great job @theogf :tada: