JuliaGaussianProcesses / KernelFunctions.jl

Julia package for kernel functions for machine learning
https://juliagaussianprocesses.github.io/KernelFunctions.jl/stable/
MIT License
267 stars 32 forks source link

Zygote AD failure workarounds & test cleanup #414

Closed st-- closed 2 years ago

st-- commented 2 years ago

Zygote seems to have changed again and we now need to revert #409

Edit: there is now a new AD failure in the select transform (#415), so temporarily disabled that test case.

In the process of trying (and failing) to figure out what's going on, I noticed that there was a lot of code duplication in test/test_utils which I've removed here (left comments to explain what I changed).

codecov[bot] commented 2 years ago

Codecov Report

Merging #414 (8b1cddc) into master (3c49949) will increase coverage by 3.50%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   89.23%   92.73%   +3.50%     
==========================================
  Files          52       52              
  Lines        1198     1198              
==========================================
+ Hits         1069     1111      +42     
+ Misses        129       87      -42     
Impacted Files Coverage Δ
src/zygoterules.jl 33.33% <0.00%> (-16.67%) :arrow_down:
src/basekernels/fbm.jl 100.00% <0.00%> (+2.38%) :arrow_up:
src/basekernels/exponential.jl 100.00% <0.00%> (+3.84%) :arrow_up:
src/test_utils.jl 94.11% <0.00%> (+3.92%) :arrow_up:
src/basekernels/matern.jl 100.00% <0.00%> (+4.00%) :arrow_up:
src/transform/chaintransform.jl 78.26% <0.00%> (+4.34%) :arrow_up:
src/mokernels/slfm.jl 100.00% <0.00%> (+4.76%) :arrow_up:
src/kernels/kerneltensorproduct.jl 98.76% <0.00%> (+4.93%) :arrow_up:
src/basekernels/sm.jl 100.00% <0.00%> (+5.88%) :arrow_up:
src/mokernels/independent.jl 100.00% <0.00%> (+6.25%) :arrow_up:
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c49949...8b1cddc. Read the comment docs.