search

JuliaGaussianProcesses / KernelFunctions.jl

Julia package for kernel functions for machine learning
https://juliagaussianprocesses.github.io/KernelFunctions.jl/stable/
MIT License
267 stars 32 forks source link

GPU Attempt 2 #472

Open willtebbutt opened 2 years ago

willtebbutt commented 2 years ago

Summary

Supercedes #470 . I messed up some of my gitconfig stuff and had commits with the wrong username etc. Easiest thing was to start again

Proposed changes

What alternatives have you considered?

Breaking changes

edit:

TODO:

  1. sort out codecov on buildkite branch
  2. sort out formatting
codecov[bot] commented 2 years ago

Codecov Report

Base: 90.00% // Head: 86.53% // Decreases project coverage by -3.47% :warning:

Coverage data is based on head (12fe669) compared to base (dede8a0). Patch coverage: 18.57% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #472 +/- ## ========================================== - Coverage 90.00% 86.53% -3.48% ========================================== Files 52 53 +1 Lines 1351 1478 +127 ========================================== + Hits 1216 1279 +63 - Misses 135 199 +64 ``` | [Impacted Files](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses) | Coverage Δ | | |---|---|---| | [src/KernelFunctions.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL0tlcm5lbEZ1bmN0aW9ucy5qbA==) | `100.00% <ø> (ø)` | | | [src/distances/cuda.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Rpc3RhbmNlcy9jdWRhLmps) | `0.00% <0.00%> (ø)` | | | [src/TestUtils.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL1Rlc3RVdGlscy5qbA==) | `47.36% <6.55%> (-47.37%)` | :arrow_down: | | [src/basekernels/fbm.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL2ZibS5qbA==) | `96.07% <77.77%> (-3.93%)` | :arrow_down: | | [src/basekernels/exponential.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL2V4cG9uZW50aWFsLmps) | `100.00% <100.00%> (ø)` | | | [src/basekernels/matern.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL21hdGVybi5qbA==) | `100.00% <100.00%> (ø)` | | | [src/basekernels/wiener.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL3dpZW5lci5qbA==) | `92.85% <100.00%> (ø)` | | | [src/transform/scaletransform.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL3RyYW5zZm9ybS9zY2FsZXRyYW5zZm9ybS5qbA==) | `100.00% <0.00%> (+13.33%)` | :arrow_up: | | [src/transform/periodic\_transform.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL3RyYW5zZm9ybS9wZXJpb2RpY190cmFuc2Zvcm0uamw=) | `50.00% <0.00%> (+20.00%)` | :arrow_up: | | [src/transform/transform.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL3RyYW5zZm9ybS90cmFuc2Zvcm0uamw=) | `100.00% <0.00%> (+40.00%)` | :arrow_up: | | ... and [5 more](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/472/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

willtebbutt commented 2 years ago

@theogf there are a couple of minor things left to do, but I think this is defintely ready for review

willtebbutt commented 1 year ago

@willtebbutt Do you think it will take some time to sort out all remaining comments and issues in this PR? If so, we could add only the buildkite configuration as a first step to fix CI errors and add GPU-specific tests in a follow-up PR, similar to https://github.com/JuliaGaussianProcesses/AbstractGPs.jl/pull/335.

That would be ideal. I thought I was going to have time to follow up on this immediately, but it's actually going to be a little while. If you could open a PR like the one you made to AbstractGPs, that would be ideal.