JuliaGaussianProcesses / KernelFunctions.jl

Julia package for kernel functions for machine learning
https://juliagaussianprocesses.github.io/KernelFunctions.jl/stable/
MIT License
267 stars 32 forks source link

Remove duplicate definition of KernelProduct #487

Closed theogf closed 1 year ago

theogf commented 1 year ago

In the last PR #486 , there was a leftover issue where

(κ::KernelProduct)(x, y)

is defined twice. This removes one of the definitions.

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.18% // Head: 71.65% // Decreases project coverage by -22.52% :warning:

Coverage data is based on head (3823782) compared to base (8b743dd). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #487 +/- ## =========================================== - Coverage 94.18% 71.65% -22.53% =========================================== Files 52 52 Lines 1375 1369 -6 =========================================== - Hits 1295 981 -314 - Misses 80 388 +308 ``` | [Impacted Files](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses) | Coverage Δ | | |---|---|---| | [src/kernels/kernelproduct.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2tlcm5lbHMva2VybmVscHJvZHVjdC5qbA==) | `100.00% <ø> (+3.33%)` | :arrow_up: | | [src/basekernels/sm.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL3NtLmps) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [src/basekernels/gabor.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL2dhYm9yLmps) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [src/basekernels/nn.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL25uLmps) | `0.00% <0.00%> (-98.00%)` | :arrow_down: | | [src/basekernels/wiener.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL3dpZW5lci5qbA==) | `0.00% <0.00%> (-92.86%)` | :arrow_down: | | [src/basekernels/rational.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL3JhdGlvbmFsLmps) | `9.67% <0.00%> (-90.33%)` | :arrow_down: | | [src/basekernels/piecewisepolynomial.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL3BpZWNld2lzZXBvbHlub21pYWwuamw=) | `0.00% <0.00%> (-89.48%)` | :arrow_down: | | [src/basekernels/exponentiated.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL2V4cG9uZW50aWF0ZWQuamw=) | `0.00% <0.00%> (-80.00%)` | :arrow_down: | | [src/basekernels/matern.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL21hdGVybi5qbA==) | `24.00% <0.00%> (-76.00%)` | :arrow_down: | | [src/basekernels/fbm.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL2ZibS5qbA==) | `26.66% <0.00%> (-73.34%)` | :arrow_down: | | ... and [9 more](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/487/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.