Closed github-actions[bot] closed 1 year ago
Base: 94.25% // Head: 94.25% // No change to project coverage :thumbsup:
Coverage data is based on head (
7c9b31d
) compared to base (768207c
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Do not merge yet -- IrrationalConstants being held back by something. Am investigating
Appears to update locally. Closed + re-opened to re-run CI.
Needs SpecialFunctions, StatsFuns, etc. I assume we might depend on one of these.
Yup. Looks like it's SpecialFunctions. Looks like it's compatible with version 1 of SpecialFunctions, but not 2. Looks like you've already opened the relevant PR, so we'll just have to wait for that to be merged
Version 0.2 of IrrationalConstants is now being used in CI. Will merge when CI passes
Are you sure? https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/actions/runs/4242302919/jobs/7373628447#step:6:96 seems to indicate it still uses IrrationalConstants 0.1 (not too surprised since e.g. StatsFuns and DiffRules are not updated yet).
Ahhh I didn't look far enough through the logs -- looks like 0.2 is getting installed, then downgraded to 0.1. Good catch
The possibly last missing package should be ChainRules. I already released updates of SpecialFunctions, StatsFuns, and DiffRules. The ChainRules PR had quite a few test failures but all of them should be unrelated.
We appear to have sporadic test failures for the FBM kernel -- this is presumably a tricky numerical issue. I've loosened the tolerance in the hope that tests will all pass. Will merge if they do.
This pull request changes the compat entry for the
IrrationalConstants
package from0.1
to0.1, 0.2
. This keeps the compat entries for earlier versions.Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.