JuliaGaussianProcesses / KernelFunctions.jl

Julia package for kernel functions for machine learning
https://juliagaussianprocesses.github.io/KernelFunctions.jl/stable/
MIT License
267 stars 32 forks source link

CompatHelper: bump compat for IrrationalConstants to 0.2, (keep existing compat) #491

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

This pull request changes the compat entry for the IrrationalConstants package from 0.1 to 0.1, 0.2. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

codecov[bot] commented 1 year ago

Codecov Report

Base: 94.25% // Head: 94.25% // No change to project coverage :thumbsup:

Coverage data is based on head (7c9b31d) compared to base (768207c). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #491 +/- ## ======================================= Coverage 94.25% 94.25% ======================================= Files 52 52 Lines 1374 1374 ======================================= Hits 1295 1295 Misses 79 79 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

willtebbutt commented 1 year ago

Do not merge yet -- IrrationalConstants being held back by something. Am investigating

willtebbutt commented 1 year ago

Appears to update locally. Closed + re-opened to re-run CI.

devmotion commented 1 year ago

Needs SpecialFunctions, StatsFuns, etc. I assume we might depend on one of these.

willtebbutt commented 1 year ago

Yup. Looks like it's SpecialFunctions. Looks like it's compatible with version 1 of SpecialFunctions, but not 2. Looks like you've already opened the relevant PR, so we'll just have to wait for that to be merged

willtebbutt commented 1 year ago

Version 0.2 of IrrationalConstants is now being used in CI. Will merge when CI passes

devmotion commented 1 year ago

Are you sure? https://github.com/JuliaGaussianProcesses/KernelFunctions.jl/actions/runs/4242302919/jobs/7373628447#step:6:96 seems to indicate it still uses IrrationalConstants 0.1 (not too surprised since e.g. StatsFuns and DiffRules are not updated yet).

willtebbutt commented 1 year ago

Ahhh I didn't look far enough through the logs -- looks like 0.2 is getting installed, then downgraded to 0.1. Good catch

devmotion commented 1 year ago

The possibly last missing package should be ChainRules. I already released updates of SpecialFunctions, StatsFuns, and DiffRules. The ChainRules PR had quite a few test failures but all of them should be unrelated.

willtebbutt commented 1 year ago

We appear to have sporadic test failures for the FBM kernel -- this is presumably a tricky numerical issue. I've loosened the tolerance in the hope that tests will all pass. Will merge if they do.