JuliaGaussianProcesses / KernelFunctions.jl

Julia package for kernel functions for machine learning
https://juliagaussianprocesses.github.io/KernelFunctions.jl/stable/
MIT License
267 stars 32 forks source link

Make `spectral_mixture_kernel` type stable for `StaticArrays` #501

Closed theogf closed 1 year ago

theogf commented 1 year ago

Fix #490 by changing the implementation (use intermediate vector representation) and checking that this works for StaticArrays.

Additionally add a note in the docs to suggest using StaticArrays to get a type stable constructor.

Replaces #500

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8746034) 94.25% compared to head (4181350) 94.25%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #501 +/- ## ======================================= Coverage 94.25% 94.25% ======================================= Files 52 52 Lines 1374 1375 +1 ======================================= + Hits 1295 1296 +1 Misses 79 79 ``` | [Impacted Files](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses) | Coverage Δ | | |---|---|---| | [src/basekernels/sm.jl](https://codecov.io/gh/JuliaGaussianProcesses/KernelFunctions.jl/pull/501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses#diff-c3JjL2Jhc2VrZXJuZWxzL3NtLmps) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaGaussianProcesses)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.