search

JuliaGaussianProcesses / LinearMixingModels.jl

http://proceedings.mlr.press/v119/bruinsma20a.html
MIT License
6 stars 0 forks source link

MOInputIsotopicByFeatures test failing on Julia 1.7 #44

Closed glennmoy closed 2 years ago

glennmoy commented 2 years ago

Looks like it could be just a matter of the significant digits of the values being compared by elbo and logpdf in AbstractGPs.TestUtils.test_internal_abstractgps_interface

MOInputIsotopicByFeatures: Test Failed at /home/runner/.julia/packages/AbstractGPs/0jusJ/src/util/test_util.jl:207
  Expression: elbo(VFE(f(z)), fx, y) <= logpdf(fx, y)
   Evaluated: -6.1470239320766975 <= -6.1470239320767

I'm not sure if an issue should be opened there (@willtebbutt ?) so I'll just make this one since this is where the error is.

https://github.com/invenia/LinearMixingModels.jl/runs/4770173820?check_suite_focus=true

willtebbutt commented 2 years ago

Hmmm this is interesting. It definitely looks like a numerical issue to me. I'll open an issue on AbstractGPs -- I think there should be an easy fix.