search

JuliaGaussianProcesses / ParameterHandling.jl

Foundational tooling for handling collections of parameters in models
MIT License
72 stars 11 forks source link

Use InverseFunctions and LogExpFunctions #42

Closed devmotion closed 3 years ago

devmotion commented 3 years ago

This PR replaces the Bijectors dependency with the more lightweight dependencies on InverseFunctions (for inverse) and LogExpFunctions (for logit and logistic).

InverseFunctions (https://github.com/JuliaMath/InverseFunctions.jl/) defines InverseFunctions.inverse as an interface for inverses of bijective functions and implements it for base functions such as exp and log. It is planned to implement it in other packages such as LogExpFunctions as well which would allow users to use eg. LogExpFunctions.log1pexp instead of the standard exp transform in positive.

Fixes https://github.com/invenia/ParameterHandling.jl/issues/24.

codecov[bot] commented 3 years ago

Codecov Report

Merging #42 (4c1f827) into master (21e6ff7) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   96.49%   96.55%   +0.06%     
==========================================
  Files           4        4              
  Lines         171      174       +3     
==========================================
+ Hits          165      168       +3     
  Misses          6        6
Impacted Files Coverage Δ
src/ParameterHandling.jl 100.00% <ø> (ø)
src/parameters.jl 97.53% <100.00%> (+0.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21e6ff7...4c1f827. Read the comment docs.