Closed simsurace closed 9 months ago
Thanks for opening this. Busy morning -- will try to review later today
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
567b070
) 97.36% compared to head (f5bdf67
) 97.40%. Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think views definitely make sense here. Very open to that.
While you do that, I'm going to drop 1.5, because we really don't need it.
Thinking it over a bit, I think going to views should be evaluated a bit more carefully, as it also requires generalizing a lot of the signatures of the unflatten
functions. I will keep that for a later PR perhaps.
I'm gonna suggest approving this as is. I bumped the version. Maybe we can release #68 in the same swoop?
Thinking it over a bit, I think going to views should be evaluated a bit more carefully, as it also requires generalizing a lot of the signatures of the unflatten functions. I will keep that for a later PR perhaps.
Good point. Yeah, let's defer that until later. I do think it would be good to look at though, because we're currently doing a lot of copying.
No problem!
On master this does not infer:
This PR fixes this and (so I believe) improves the type inference with a recursive implementation and a fallback for empty tuples.